This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Porep Gas charge reduced 4x past v7 #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
approved these changes
Nov 12, 2020
acruikshank
approved these changes
Nov 12, 2020
actors/builtin/power/power_actor.go
Outdated
| @@ -259,10 +260,15 @@ func (a Actor) UpdatePledgeTotal(rt Runtime, pledgeDelta *abi.TokenAmount) *abi. | |||
| // This number is empirically determined | |||
| const GasOnSubmitVerifySeal = 34721049 | |||
There was a problem hiding this comment.
Not a big deal, but you may want to make this point to the constant in the V0 repo the way we do parameter types.
Kubuxu
pushed a commit
that referenced
this pull request
Nov 14, 2020
This reverts commit d84628a. Signed-off-by: Jakub Sztandera <[email protected]>
ZenGround0
pushed a commit
that referenced
this pull request
Nov 14, 2020
This reverts commit d84628a. Signed-off-by: Jakub Sztandera <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gas rebalancing here puts PoRep gas charges 4x lower to account for speedup in default proofs implementation. @Kubuxu has requested we include this in actors v2.3.x. Iit is high impact and a simple change hence this PR.