Incorrect errorcode?

[laudiacay]

specs-actors/actors/builtin/miner/miner_actor.go

Lines 869 to 870 in 97fc448

	aggSectorsCount, err := params.SectorNumbers.Count()
	builtin.RequireNoErr(rt, err, exitcode.ErrIllegalState, "failed to count aggregated sectors")

this should probably be an errIllegalArgument, no? the params failed validation?

[ZenGround0]

It's a bit of an edge case but I don't think so. ErrIllegalArgument for values actor logic forbids. ErrIllegalState for failures that should be impossible. In this case the bitfield was serialized correctly but makes Count fail which I wouldn't expect to be possible. If you look into it and Count errors are expected for certain valid serializations I'll support changing to ErrIllegalArgument.

[Stebalien]

Well, the serialization may not actually be valid. We check lazily when we actually operate on the bitfield to avoid validating bitfields in the state every time we rehydrate them.