Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Publish valid deals in PublishStorageDeals message #1375

Closed
jennijuju opened this issue Feb 4, 2021 · 3 comments
Closed

Publish valid deals in PublishStorageDeals message #1375

jennijuju opened this issue Feb 4, 2021 · 3 comments
Assignees
@ZenGround0
Labels
fip Issue likely needs its own FIP
Milestone
Network v14

Comments

@jennijuju
Copy link
Member

Currently the market actor validates each deal, if one of the deals fails validation, the whole message fails. One of the validation is checking if the deal's start epoch has already passed and due to network's mpool congestion issue, it is possible that by the time a PublishStorageDeals message lands on-chain, the deal has already expired even though the message was sent beforehand.

It would be nice to only fail the invalid deals and have the valid one to be published successfully.
@dirkmc dirkmc mentioned this issue Feb 4, 2021
Merged
@jennijuju jennijuju mentioned this issue Feb 23, 2021
Closed
3 tasks
@ZenGround0 ZenGround0 mentioned this issue Apr 8, 2021
Closed
28 tasks
@jennijuju jennijuju added this to the 🤝 Deal Success milestone May 20, 2021
@jennijuju jennijuju added the fip Issue likely needs its own FIP label May 20, 2021
@jennijuju
Copy link
Member Author

@dkkapur Could you please add the link to the FIP discussion or FIP itself once created?

@jennijuju jennijuju mentioned this issue Aug 16, 2021
Open
@ZenGround0
Copy link
Contributor

FIP discussion happening here: filecoin-project/FIPs#142

@ZenGround0
Copy link
Contributor

Closed by #1487

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ZenGround0 ZenGround0

Labels
fip Issue likely needs its own FIP
Projects
None yet
Milestone
Network v14
Development

No branches or pull requests
2 participants
@ZenGround0 @jennijuju