Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seal_pre_commit_phase1 should allow /dev/zero as in_file #1664

Closed
magik6k opened this issue Feb 28, 2023 · 0 comments · Fixed by #1681
Closed

seal_pre_commit_phase1 should allow /dev/zero as in_file #1664

magik6k opened this issue Feb 28, 2023 · 0 comments · Fixed by #1681

Comments

@magik6k
Copy link

magik6k commented Feb 28, 2023

Currently passing /dev/zero to PC1 will fail with in_path must be a file. This would be a good optimization for CC sectors.

Bonus points if proofs would skip TreeD compute for all-zero data since we can easily precompute all levels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(filecoin-proofs): allow PC1 unreplicated data to be /dev/zero filecoin-project/rust-fil-proofs
1 participant
@magik6k