Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: precommits info #8696

Merged
merged 5 commits into from
May 23, 2022
Merged

feat: precommits info #8696

merged 5 commits into from
May 23, 2022

Conversation

swift-mx
Copy link
Contributor

@swift-mx swift-mx requested a review from a team as a code owner May 23, 2022 04:55
magik6k
magik6k reviewed May 23, 2022
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, just two small comments.

cmd/lotus-miner/precommits-info.go Outdated Show resolved Hide resolved
cmd/lotus-miner/precommits-info.go Outdated Show resolved Hide resolved
@swift-mx
Copy link
Contributor Author

Thanks, looks good, just two small comments.

good suggestion , i have commited it . do you have any other suggestions ?

@magik6k magik6k merged commit 5805598 into filecoin-project:master May 23, 2022
@Fatman13
Copy link
Contributor

Is documentation/en/cli-lotus-miner.md manually maintained or is there any tools for generating the CLIs?

@rjan90
Copy link
Contributor

rjan90 commented May 27, 2022

Hey @Fatman13! If I´m not mistaken the cli-lotus-miner.md is automatically generated using make docsgen-cli

lotus/Makefile

Lines 354 to 359 in 7836e20

# separate from gen because it needs binaries
docsgen-cli: lotus lotus-miner lotus-worker
python ./scripts/generate-lotus-cli.py
./lotus config default > documentation/en/default-lotus-config.toml
./lotus-miner config default > documentation/en/default-lotus-miner-config.toml
.PHONY: docsgen-cli

@ghost ghost mentioned this pull request Jan 21, 2024
Closed
@NateWebb03 NateWebb03 mentioned this pull request Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swift-mx @Fatman13 @rjan90 @magik6k