Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: market utils: Support unixfsnode in TraverseDag #8168

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Feb 22, 2022

Related Issues

Proposed Changes

This adds support for UnixFS ADLs in client parts of lotus.

Additional Info

Client-side only. Providers already have support for those through Graphsync - https://github.com/ipfs/go-graphsync/blob/8c66ab9e2f562386c59fba2700bb1fcf8c743675/storeutil/storeutil.go#L46

@magik6k magik6k requested a review from a team as a code owner February 22, 2022 09:52
@magik6k magik6k merged commit 7c2f653 into master Feb 23, 2022
@magik6k magik6k deleted the feat/ufs-selectors branch February 23, 2022 21:35
@hannahhoward
Copy link
Contributor

@magik6k @willscott

if err := utils.TraverseDag(

I'm mildly concerned about this -- we probably explicitly DON'T want unixfs reification (especially HAMT) when writing a CAR.

@willscott
Copy link
Contributor

are we going to have a user-configurable selector where we'd have the potential for ADL signalling in that case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants