Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build: update the snap proofs in testplans #8042

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

jennijuju
Copy link
Member

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@jennijuju jennijuju requested a review from a team as a code owner February 8, 2022 07:11
@jennijuju jennijuju added this to the v1.14.0 milestone Feb 8, 2022
@arajasek arajasek mentioned this pull request Feb 9, 2022
5 tasks
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #8042 (73208b8) into release/v1.14.0 (da31b61) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.14.0    #8042      +/-   ##
===================================================
- Coverage            39.33%   39.33%   -0.01%     
===================================================
  Files                  657      657              
  Lines                70867    70867              
===================================================
- Hits                 27878    27874       -4     
- Misses               38171    38183      +12     
+ Partials              4818     4810       -8     
Impacted Files Coverage Δ
chain/actors/builtin/miner/diff.go 52.94% <0.00%> (-5.89%) ⬇️
chain/stmgr/call.go 71.51% <0.00%> (-3.64%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/events/events_height.go 68.90% <0.00%> (-2.53%) ⬇️
storage/wdpost_sched.go 77.45% <0.00%> (-1.97%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-0.95%) ⬇️
extern/sector-storage/stores/local.go 59.16% <0.00%> (-0.84%) ⬇️
extern/sector-storage/sched.go 83.95% <0.00%> (-0.83%) ⬇️
chain/store/store.go 63.66% <0.00%> (-0.67%) ⬇️
chain/gen/gen.go 68.80% <0.00%> (-0.62%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da31b61...73208b8. Read the comment docs.

@jennijuju jennijuju merged commit 3b5f367 into release/v1.14.0 Feb 9, 2022
@jennijuju jennijuju deleted the jen/testplanproof branch February 9, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants