Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: shed: storage stats 2.0 #7941

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

ribasushi
Copy link
Collaborator

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@ribasushi ribasushi requested a review from a team as a code owner January 13, 2022 16:29
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #7941 (e3c250f) into master (60fae3a) will increase coverage by 4.98%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7941      +/-   ##
==========================================
+ Coverage   34.32%   39.30%   +4.98%     
==========================================
  Files         652      658       +6     
  Lines       70842    71158     +316     
==========================================
+ Hits        24317    27972    +3655     
+ Misses      42039    38362    -3677     
- Partials     4486     4824     +338     
Impacted Files Coverage Δ
cmd/lotus-shed/storage-stats.go 0.00% <0.00%> (ø)
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
storage/wdpost_sched.go 77.45% <0.00%> (-3.93%) ⬇️
miner/miner.go 57.37% <0.00%> (-1.64%) ⬇️
node/impl/storminer.go 22.47% <0.00%> (-0.34%) ⬇️
extern/sector-storage/stores/local.go 59.16% <0.00%> (ø)
journal/mockjournal/journal.go 71.42% <0.00%> (ø)
chain/types/mock/chain.go 86.66% <0.00%> (ø)
chain/vectors/gen/main.go 2.36% <0.00%> (ø)
... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60fae3a...e3c250f. Read the comment docs.

@magik6k magik6k merged commit eff73c9 into master Feb 9, 2022
@magik6k magik6k deleted the chore/more_detailed_network-wide_shed_stats branch February 9, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants