Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: docs: remove issue number from the pr title #7902

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Conversation

jennijuju
Copy link
Member

@jennijuju jennijuju commented Jan 8, 2022

issue number in PR title is not that useful because reader cannot click it and need to mention the issue in the body for auto close either way.

Related Issues

Proposed Changes

remove issue number from the pr title

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

issue number in PR title is not that useful because reader cannot click it and need to mention the issue in the body for auto close either way.
@jennijuju jennijuju requested a review from a team as a code owner January 8, 2022 00:02
@jennijuju jennijuju requested a review from Kubuxu January 8, 2022 00:03
Copy link
Contributor

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very efficient PR description. :p

@jennijuju jennijuju merged commit 4abcdd8 into master Jan 10, 2022
@jennijuju jennijuju deleted the jennijuju-patch-1 branch January 10, 2022 03:49
@jennijuju
Copy link
Member Author

This is a very efficient PR description. :p

😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants