Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: n/a sealing: Fix grammatical error in a log warning message #7831

Merged
merged 2 commits into from
Dec 20, 2021
Merged

misc: n/a sealing: Fix grammatical error in a log warning message #7831

merged 2 commits into from
Dec 20, 2021

Conversation

shotcollin
Copy link
Contributor

Related Issues

No related issues; motivation is grammatically correct log warnings.

Proposed Changes

This pull request fixes a typographical error in a log warning message.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

very minor but this warning comes up a lot so it'd be nicer if it wasn't a grammatical error too
@shotcollin shotcollin requested a review from a team as a code owner December 20, 2021 00:26
@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #7831 (a259c7b) into master (dd20829) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7831      +/-   ##
==========================================
- Coverage   39.52%   39.44%   -0.08%     
==========================================
  Files         654      654              
  Lines       70013    70013              
==========================================
- Hits        27671    27615      -56     
- Misses      37594    37644      +50     
- Partials     4748     4754       +6     
Impacted Files Coverage Δ
extern/sector-storage/partialfile/partialfile.go 43.90% <0.00%> (ø)
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
chain/gen/slashfilter/slashfilter.go 40.00% <0.00%> (-12.00%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
chain/stmgr/execute.go 86.95% <0.00%> (-4.35%) ⬇️
chain/messagepool/repub.go 51.61% <0.00%> (-4.31%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
miner/miner.go 54.96% <0.00%> (-2.65%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-1.97%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-1.96%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd20829...a259c7b. Read the comment docs.

@magik6k magik6k enabled auto-merge December 20, 2021 14:38
@magik6k magik6k merged commit daa2d89 into filecoin-project:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants