Expose EnableGasTracing as an env_var #7750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7750 +/- ##
==========================================
- Coverage 39.57% 39.54% -0.03%
==========================================
Files 640 640
Lines 68468 68468
==========================================
- Hits 27095 27079 -16
- Misses 36722 36738 +16
Partials 4651 4651
Continue to review full report at Codecov.
|
geoff-vball
force-pushed
the
gstuart/lotus-vm-gas-tracing-env-var
branch
from
cbec238 to
25420cf
Compare
geoff-vball
changed the title
geoff-vball
changed the title
geoff-vball
force-pushed
the
gstuart/lotus-vm-gas-tracing-env-var
branch
4 times, most recently
from
4e9957e to
070d17f
Compare
magik6k
reviewed
Dec 10, 2021
chain/vm/runtime.go
Outdated
| @@ -51,8 +52,7 @@ func (m *Message) ValueReceived() abi.TokenAmount { | |||
| return m.msg.Value | |||
| } | |||
|
|
|||
| // EnableGasTracing, if true, outputs gas tracing in execution traces. | |||
| var EnableGasTracing = false | |||
| const EnableGasTracingEnvVar = "LOTUS_VM_ENABLE_GAS_TRACING_VERY_SLOW" | |||
There was a problem hiding this comment.
I'd do
Suggested change
| const EnableGasTracingEnvVar = "LOTUS_VM_ENABLE_GAS_TRACING_VERY_SLOW" | |
| // EnableGasTracing, if true, outputs gas tracing in execution traces. | |
| var EnableGasTracing = os.Getenv("LOTUS_VM_ENABLE_GAS_TRACING_VERY_SLOW") == "1" |
So that we don't have to lookup the env var on every gas charge
There was a problem hiding this comment.
Changed, thanks that makes it a lot simpler.
geoff-vball
force-pushed
the
gstuart/lotus-vm-gas-tracing-env-var
branch
from
070d17f to
9108828
Compare
arajasek
approved these changes
Dec 10, 2021
magik6k
approved these changes
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #7648