Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dagstore pieceReader: Always read full in ReadAt #7737

Merged
merged 4 commits into from
Dec 6, 2021
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Dec 3, 2021

Probably want this in 1.13.2

@magik6k magik6k requested a review from a team as a code owner December 3, 2021 19:12
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #7737 (84c48de) into master (9d14342) will increase coverage by 0.00%.
The diff coverage is 82.35%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7737   +/-   ##
=======================================
  Coverage   39.56%   39.57%           
=======================================
  Files         640      640           
  Lines       68350    68364   +14     
=======================================
+ Hits        27042    27052   +10     
- Misses      36658    36664    +6     
+ Partials     4650     4648    -2     
Impacted Files Coverage Δ
metrics/metrics.go 100.00% <ø> (ø)
markets/dagstore/piecereader.go 60.81% <82.35%> (+4.14%) ⬆️
chain/sub/incoming.go 54.43% <0.00%> (-3.38%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-1.70%) ⬇️
extern/storage-sealing/fsm.go 55.77% <0.00%> (-1.60%) ⬇️
itests/kit/blockminer.go 93.65% <0.00%> (-1.59%) ⬇️
chain/stmgr/searchwait.go 66.02% <0.00%> (-1.29%) ⬇️
extern/sector-storage/sched.go 84.77% <0.00%> (-0.83%) ⬇️
storage/wdpost_run.go 69.62% <0.00%> (-0.64%) ⬇️
chain/sync_manager.go 66.77% <0.00%> (-0.63%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d14342...84c48de. Read the comment docs.

@magik6k magik6k added this to the v1.13.2 milestone Dec 4, 2021
@magik6k magik6k force-pushed the feat/opt-ds-pr branch 2 times, most recently from 1e37138 to 9f6265e Compare December 6, 2021 11:16
@magik6k magik6k mentioned this pull request Dec 6, 2021
18 tasks
@jennijuju jennijuju changed the base branch from master to release/v1.13.2 December 6, 2021 20:27
@jennijuju jennijuju changed the base branch from release/v1.13.2 to master December 6, 2021 20:27
@magik6k magik6k merged commit 9ccd4ee into master Dec 6, 2021
@magik6k magik6k deleted the feat/opt-ds-pr branch December 6, 2021 22:14
@jennijuju jennijuju mentioned this pull request Dec 8, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants