Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logic error #7709

Merged
merged 1 commit into from
Nov 29, 2021
Merged

fix logic error #7709

merged 1 commit into from
Nov 29, 2021

Conversation

coryschwartz
Copy link

obviously, we want to run the init if the gate file doesn't exist.

@coryschwartz coryschwartz requested a review from a team as a code owner November 29, 2021 21:53
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #7709 (27efbc3) into master (6c0374c) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7709      +/-   ##
==========================================
- Coverage   39.60%   39.54%   -0.07%     
==========================================
  Files         635      635              
  Lines       67551    67551              
==========================================
- Hits        26754    26711      -43     
- Misses      36203    36240      +37     
- Partials     4594     4600       +6     
Impacted Files Coverage Δ
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-5.89%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
blockstore/buffered.go 40.00% <0.00%> (-2.23%) ⬇️
extern/sector-storage/stores/local.go 57.30% <0.00%> (-1.97%) ⬇️
itests/kit/blockminer.go 93.65% <0.00%> (-1.59%) ⬇️
extern/storage-sealing/fsm.go 55.77% <0.00%> (-1.20%) ⬇️
chain/store/store.go 63.00% <0.00%> (-1.17%) ⬇️
storage/wdpost_run.go 69.62% <0.00%> (-1.06%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0374c...27efbc3. Read the comment docs.

@jennijuju jennijuju added this to the v1.13.2 milestone Nov 29, 2021
@jennijuju jennijuju merged commit 01215b7 into master Nov 29, 2021
@jennijuju jennijuju deleted the logic-error-miner-entrypoint branch November 29, 2021 23:17
@coder-chenda
Copy link

I use the docker method to start and run the node. I would like to ask if the fix of this bug affects the start and operation of docker? @jennijuju @coryschwartz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants