Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect and expose graphsync metrics #7542

Merged
merged 6 commits into from
Oct 20, 2021
Merged

Collect and expose graphsync metrics #7542

merged 6 commits into from
Oct 20, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Oct 19, 2021

No description provided.

@magik6k magik6k requested a review from a team as a code owner October 19, 2021 17:56
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #7542 (d2e9d21) into master (d910098) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head d2e9d21 differs from pull request most recent head b7fe165. Consider uploading reports for the commit b7fe165 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7542      +/-   ##
==========================================
- Coverage   39.84%   39.76%   -0.09%     
==========================================
  Files         632      632              
  Lines       66955    66998      +43     
==========================================
- Hits        26681    26640      -41     
- Misses      35683    35745      +62     
- Partials     4591     4613      +22     
Impacted Files Coverage Δ
metrics/metrics.go 100.00% <100.00%> (ø)
node/modules/graphsync.go 87.50% <100.00%> (+14.42%) ⬆️
node/modules/storageminer.go 63.11% <100.00%> (+0.06%) ⬆️
chain/stmgr/call.go 67.87% <0.00%> (-7.28%) ⬇️
miner/miner.go 51.65% <0.00%> (-5.30%) ⬇️
extern/sector-storage/manager_calltracker.go 57.70% <0.00%> (-4.85%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-4.67%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/sync.go 65.27% <0.00%> (-2.01%) ⬇️
extern/sector-storage/sched.go 83.05% <0.00%> (-1.66%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d910098...b7fe165. Read the comment docs.

@magik6k magik6k merged commit 97e4921 into master Oct 20, 2021
@magik6k magik6k deleted the feat/gs-metrics branch October 20, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants