Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] was withdrawn, let's not depend on it directly #7481

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

ribasushi
Copy link
Collaborator

As per slack conversation - while this is probably harmless, we should just fix go.mod

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #7481 (6184e8a) into master (c776811) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7481      +/-   ##
==========================================
+ Coverage   39.23%   39.24%   +0.01%     
==========================================
  Files         631      631              
  Lines       66853    66853              
==========================================
+ Hits        26232    26239       +7     
+ Misses      36054    36042      -12     
- Partials     4567     4572       +5     
Impacted Files Coverage Δ
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/stmgr/searchwait.go 66.02% <0.00%> (-2.57%) ⬇️
node/modules/core.go 46.46% <0.00%> (-2.03%) ⬇️
node/repo/memrepo.go 69.50% <0.00%> (-2.00%) ⬇️
storage/wdpost_sched.go 75.24% <0.00%> (-1.99%) ⬇️
markets/storageadapter/dealpublisher.go 81.06% <0.00%> (-1.95%) ⬇️
node/impl/full/mpool.go 23.47% <0.00%> (-1.74%) ⬇️
extern/sector-storage/sched.go 83.05% <0.00%> (-1.66%) ⬇️
itests/kit/deals.go 82.98% <0.00%> (-1.55%) ⬇️
lib/rpcenc/reader.go 70.29% <0.00%> (-1.49%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c776811...6184e8a. Read the comment docs.

@jennijuju
Copy link
Member

does this have to be backported tho?

@ribasushi
Copy link
Collaborator Author

@jennijuju yes, because it is unclear what the effect of this has on an end-user trying to depend on latest lotus
0.2.9 and 0.3.0 are identical inside, there's no need to retest anything

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ribasushi
Copy link
Collaborator Author

@marten-seemann could you please also confirm I am correct here: #7481 (comment)

0.2.9 and 0.3.0 are identical inside, there's no need to retest anything

@marten-seemann
Copy link
Contributor

0.2.9 and 0.3.0 are identical inside, there's no need to retest anything

That is correct, see libp2p/go-libp2p-peerstore@v0.2.9...v0.3.0.

@magik6k magik6k merged commit c6b28b4 into master Oct 11, 2021
@magik6k magik6k deleted the chore/cleanup-withdrawn-dependency branch October 11, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants