-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] was withdrawn, let's not depend on it directly #7481
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7481 +/- ##
==========================================
+ Coverage 39.23% 39.24% +0.01%
==========================================
Files 631 631
Lines 66853 66853
==========================================
+ Hits 26232 26239 +7
+ Misses 36054 36042 -12
- Partials 4567 4572 +5
Continue to review full report at Codecov.
|
does this have to be backported tho? |
@jennijuju yes, because it is unclear what the effect of this has on an end-user trying to depend on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@marten-seemann could you please also confirm I am correct here: #7481 (comment)
|
That is correct, see libp2p/go-libp2p-peerstore@v0.2.9...v0.3.0. |
As per slack conversation - while this is probably harmless, we should just fix go.mod