Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase threshold from 0.5% to 1% #7262

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

ZenGround0
Copy link
Contributor

Codecov randomly goes down more than 1% for PRs that don't change any code

@ZenGround0 ZenGround0 requested a review from a team as a code owner September 2, 2021 20:07
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #7262 (56acfe3) into master (baa1ec0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7262   +/-   ##
=======================================
  Coverage   39.11%   39.11%           
=======================================
  Files         614      614           
  Lines       64895    64895           
=======================================
  Hits        25383    25383           
+ Misses      35120    35117    -3     
- Partials     4392     4395    +3     
Impacted Files Coverage Δ
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
extern/sector-storage/manager_calltracker.go 59.03% <0.00%> (-3.53%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
miner/miner.go 55.29% <0.00%> (-1.99%) ⬇️
chain/stmgr/actors.go 44.26% <0.00%> (-0.64%) ⬇️
chain/messagepool/messagepool.go 56.87% <0.00%> (-0.62%) ⬇️
chain/messagepool/selection.go 80.52% <0.00%> (-0.41%) ⬇️
node/impl/full/state.go 34.14% <0.00%> (-0.25%) ⬇️
storage/wdpost_run.go 70.04% <0.00%> (-0.22%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa1ec0...56acfe3. Read the comment docs.

@magik6k magik6k enabled auto-merge September 2, 2021 20:21
@magik6k magik6k merged commit 212400b into master Sep 2, 2021
@magik6k magik6k deleted the chore/tweak-codecov-threshold branch September 2, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants