-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sealing: Check piece CIDs after AddPiece #7185
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7185 +/- ##
==========================================
+ Coverage 33.80% 39.02% +5.22%
==========================================
Files 601 607 +6
Lines 64277 64577 +300
==========================================
+ Hits 21728 25204 +3476
+ Misses 38464 34985 -3479
- Partials 4085 4388 +303
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both solution seem to work fine, although the first one is arguably safer.
fc68aae
to
b42171d
Compare
Ok, integration tests disabled entirely. |
It's not really safer, we only really use the info about which bits of the unsealed sector file are allocated to check if we need to Unseal the sector before reading unsealed data. |
Non-worker-api-breaking alternative to #7175
The difference here is that after adding a bad piece ta a sector, it will be market as 'allocated' in the sector file, but that's actually fine as we allow overwriting allocated parts of sectors - the only thing we need to do to recover from this is to not add the bad piece to the
sector.Pieces
array, and the subsequent AddPiece calls will overwrite the bad data with good data