Add expected CID param to AddPiece #7175
Conversation
magik6k
force-pushed
the
feat/ap-cid-check
branch
2 times, most recently
from
9ebc95d to
1af8d96
Compare
magik6k
force-pushed
the
feat/ap-cid-check
branch
from
1af8d96 to
1916a78
Compare
| @@ -167,6 +167,7 @@ Inputs: | |||
| }, | |||
| null, | |||
| 1024, | |||
| null, | |||
There was a problem hiding this comment.
This shouldn't change. Do we need to stub out a version of the v0 API that passes nil?
There was a problem hiding this comment.
This is the worker API which is mostly internal, and generally ok to change
There was a problem hiding this comment.
Yeah... but is there any real reason to? Alternatively, if it's internal, is there any way to make sure it's always in the "unstable" API, and never gets stabilized?
There was a problem hiding this comment.
I'd call this API 'internal'.
That said, changing it does require miners to update all their workers, which can be quite inconvenient.. I maybe see a way to make this work without changing this API
|
Flaky test disabled in #7176. |
Codecov Report
@@ Coverage Diff @@
## master #7175 +/- ##
==========================================
+ Coverage 30.29% 34.82% +4.52%
==========================================
Files 677 684 +7
Lines 79752 80153 +401
==========================================
+ Hits 24159 27910 +3751
+ Misses 50279 46583 -3696
- Partials 5314 5660 +346
Continue to review full report at Codecov.
|
|
#7185 was merged (with no worker-api breakage) |
Should address #7146 by making it impossible to put corrupted pieces into sectors (note that after one AddPiece call fails, subsequent calls should overwrite the bad data)