Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rice box to required binaries #7125

Merged
merged 2 commits into from
Aug 18, 2021
Merged

add rice box to required binaries #7125

merged 2 commits into from
Aug 18, 2021

Conversation

travisperson
Copy link
Contributor

This is a temporary fix to resolve #6715 to ensure we do not break the devnet / testnet faucet on automated deployments.

@travisperson travisperson requested a review from a team as a code owner August 18, 2021 17:26
@travisperson
Copy link
Contributor Author

@jennijuju I'm going to be a temporary block on updating the faucet service during release deployments till this lands in an rc. Everything else will still work, just no changes the the faucet will automatically update which are infrequently anyways so no big issues I think.

@travisperson
Copy link
Contributor Author

This isn't a complete fix. Townhall still depends on rice, but whatever folder it's using doesn't exist, and probably requires an additional build step to produce that is not being done in circle. This caused the build to fail.

@jennijuju
Copy link
Member

Thanks @travisperson - what’s devnet faucet?

@travisperson
Copy link
Contributor Author

travisperson commented Aug 18, 2021

Every network we setup has a faucet, The devnets we run are butterfly, interop, etc.

@jennijuju
Copy link
Member

Every network we setup has a faucet, The devnets we run are butterfly, interop, etc.

Ah didn’t realize we call them devnets instead testnet , thanks

@jennijuju jennijuju merged commit 28bf968 into master Aug 18, 2021
@jennijuju jennijuju deleted the fix/rice-box branch August 18, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Remove go.rice completely from lotus
3 participants