polish(errors): better state tree errors #6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jul 29, 2021
chain/state/statetree.go
Outdated
| @@ -273,7 +273,7 @@ func LoadStateTree(cst cbor.IpldStore, c cid.Cid) (*StateTree, error) { | |||
| } | |||
| if err != nil { | |||
| log.Errorf("failed to load state tree: %s", err) | |||
| return nil, xerrors.Errorf("failed to load state tree: %w", err) | |||
| return nil, xerrors.Errorf("failed to load state tree %s: %w", c.String(), err) | |||
There was a problem hiding this comment.
Don't bother calling .String(), it'll be called automatically when formatting.
frrist
force-pushed
the
frrist/better-state-tree-errors
branch
from
9cd689d to
256d127
Compare
|
addressed. |
Stebalien
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StateTree is failing to load for Lily is processing the chain. Make these errors more informative.