Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce entropy in the chain package #6889

Merged
merged 13 commits into from
Jul 27, 2021
Merged

Reduce entropy in the chain package #6889

merged 13 commits into from
Jul 27, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jul 27, 2021

The chain package has grown rather.. organically for the past ~2 years, this PR attempts to organize some things better.

  • Mostly splitting / sorting big go files
  • Dropping one or two unused functions
  • Removes vs.Syscalls from chainstore as it definitely doesn't belong there

@magik6k magik6k requested a review from a team as a code owner July 27, 2021 15:49
Stebalien
Stebalien approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, this is 90% moved code. Assuming there are no major changes that I'm missing, LGTM.

(but if there are major changes, I definitely missed them so please call them out)

chain/stmgr/upgrades.go Show resolved Hide resolved
chain/store/snapshot.go Show resolved Hide resolved
@jennijuju jennijuju added this to the v1.11.2 milestone Jul 27, 2021
@jennijuju jennijuju added the P2 P2: Should be resolved label Jul 27, 2021
@jennijuju jennijuju requested a review from arajasek July 27, 2021 21:17
@jennijuju jennijuju merged commit c31e559 into master Jul 27, 2021
@jennijuju jennijuju deleted the chore/cleanup-chain branch July 27, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@arajasek arajasek Awaiting requested review from arajasek

Assignees
No one assigned
Labels
P2 P2: Should be resolved
Projects
None yet
Milestone
v1.11.2
Development

Successfully merging this pull request may close these issues.
3 participants
@magik6k @Stebalien @jennijuju