wrap close(wait) with sync.Once to avoid panic #6800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
force-pushed
the
nonsense/fix-double-close-panic
branch
from
2f69acf to
1a1bace
Compare
raulk
approved these changes
Jul 20, 2021
raulk
force-pushed
the
nonsense/fix-double-close-panic
branch
from
1a1bace to
26a6740
Compare
Stebalien
reviewed
Jul 20, 2021
| @@ -134,7 +145,9 @@ func ReaderParamDecoder() (http.HandlerFunc, jsonrpc.ServerOption) { | |||
| } | |||
|
|
|||
| select { | |||
| case <-wr.wait: | |||
| case <-wr.watch: | |||
| // TODO should we check if we failed the Read, and if so | |||
There was a problem hiding this comment.
Yes, but a followup patch sounds reasonable.
Stebalien
force-pushed
the
nonsense/fix-double-close-panic
branch
from
1510ab7 to
8413c08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6792
Fixes the panic described in the issue. Clients are reading up until EOF error, and at that point if
Close()is called, the process was crashing.