Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache loaded block messages #6760

Merged
merged 1 commit into from
Jul 22, 2021
Merged

cache loaded block messages #6760

merged 1 commit into from
Jul 22, 2021

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Jul 15, 2021 •
edited
Loading

GetBlockMessages Is a high-load API, use cache to reduce network traffic

magik6k
magik6k reviewed Jul 15, 2021
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just one naming nitpick.

It would also be great to have a test which asserts that the cache works, for example by asserting that the ChainGetBlockMessages method is only called once per tipset

chain/events/events_called.go Outdated Show resolved Hide resolved
@hunjixin hunjixin force-pushed the feat/cache_blkmsg_events branch from 63bbfb2 to 7a69a6a Compare July 19, 2021 07:13
@hunjixin hunjixin requested a review from a team as a code owner July 19, 2021 07:13
@hunjixin hunjixin force-pushed the feat/cache_blkmsg_events branch from 7a69a6a to eef3fd5 Compare July 19, 2021 07:14
@hunjixin
Copy link
Contributor Author

@magik6k

magik6k
magik6k approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@magik6k magik6k merged commit 3006dda into filecoin-project:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hunjixin @magik6k