Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitstore code reorg #6756

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Splitstore code reorg #6756

merged 1 commit into from
Jul 14, 2021

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Jul 14, 2021

A no functional changes refactor on top of #6754 that breaks the gigantic splitstore.go file in smaller files.

There is a small typo fix, whereby I emacs-snafu'ed an nn at the end of a comment.

@vyzo vyzo requested a review from Stebalien July 14, 2021 18:20
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But this time, I'm not going to merge this till ready.

@vyzo vyzo force-pushed the feat/splitstore-refactor branch from 7a89edc to 3f3a12b Compare July 14, 2021 20:00
@vyzo vyzo force-pushed the feat/splitstore-reorg branch from 02ef0de to 05b6ec9 Compare July 14, 2021 20:01
@vyzo
Copy link
Contributor Author

vyzo commented Jul 14, 2021

rebased on the base.

Base automatically changed from feat/splitstore-refactor to master July 14, 2021 20:10
@Stebalien Stebalien force-pushed the feat/splitstore-reorg branch from 05b6ec9 to 5a23f64 Compare July 14, 2021 20:11
@Stebalien Stebalien enabled auto-merge July 14, 2021 20:11
@Stebalien Stebalien merged commit 81d614a into master Jul 14, 2021
@Stebalien Stebalien deleted the feat/splitstore-reorg branch July 14, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants