Handle the --color flag via proper global state #6743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `color.NoColor` as a global progressively modified as one descends
down command flags. Allows non-surprising operation when --color is
accepted at multiple layers, and even makes this behave predictably:
lotus-miner --color actor control list --color=false
iand
approved these changes
Jul 13, 2021
| // Set the global default, to be overridden by individual cli flags in order | ||
| func init() { | ||
| color.NoColor = os.Getenv("GOLOG_LOG_FMT") != "color" && | ||
| !isatty.IsTerminal(os.Stdout.Fd()) && |
There was a problem hiding this comment.
Strictly I think you should check GOLOG_OUTPUT to see if logging is being redirected to stderr here
There was a problem hiding this comment.
Urgh... that's a bit of a can of worms...
Perhaps we should just make this a public method and inspect the result?
https://github.com/ipfs/go-log/blob/5b4daa4491c2cc9e0ba85ce4b5fcc913f6fcdf6b/setup.go#L274-L377
There was a problem hiding this comment.
Sensible suggestion to avoid duplicating that logic
There was a problem hiding this comment.
Need to think about this more, that'll have to come via another PR
magik6k
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
color.NoColoras a global progressively modified as one descendsdown command flags. Allows non-surprising operation when --color is
accepted at multiple layers, and even makes this behave predictably:
Thanks to @stuberman for poking me about the current state being non-ideal, and to @iand for prompting me to reexamine how we do things
P.S. GNU-getopt 4EVAH‼️