polish(statetree): accept a context in statetree diff for timeouts #6639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this operation can take a while, this changes gives users the option to abort if it takes "too long".
|
This is the pattern I expected, so 👍 from me |
iand
reviewed
Jul 1, 2021
| return ctx.Err() | ||
| default: | ||
| var act types.Actor | ||
|
|
There was a problem hiding this comment.
I would normally close the select here with the default case being essentially a no-op. The context check then becomes like an early return.
magik6k
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to abort if it takes "too long".
Motivation: this operation takes a while for sentinel to perform, we'd like to abort if it takes too long.
@iand if this looks alright to you I'll tag lotus devs for a second look