Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config for collateral from miner available balance #6629

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Config for collateral from miner available balance #6629

merged 3 commits into from
Jul 13, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jun 29, 2021

Closes #6603

@magik6k magik6k requested review from arajasek and jennijuju June 29, 2021 16:21
arajasek
arajasek reviewed Jun 29, 2021
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct, but I would definitely prefer a minimum amount instead of just a boolean use / don't use.

node/config/def.go Show resolved Hide resolved
@magik6k magik6k force-pushed the feat/pledge-from-miner-balance branch 7 times, most recently from d2738a4 to 3bbdf15 Compare July 13, 2021 10:57
arajasek
arajasek approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

node/config/def.go
@@ -324,6 +331,10 @@ func DefaultStorageMiner() *StorageMiner {
AlwaysKeepUnsealedCopy: true,
FinalizeEarly: false,

CollateralFromMinerBalance: false,
AvailableBalanceBuffer: types.FIL(big.Zero()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 0 the best default here? I guess it's okay because CollateralFromMinerBalance is defaulting to false anyway.

extern/storage-sealing/utils.go Outdated Show resolved Hide resolved
@magik6k magik6k force-pushed the feat/pledge-from-miner-balance branch from 3bbdf15 to e44c940 Compare July 13, 2021 15:04
@magik6k magik6k force-pushed the feat/pledge-from-miner-balance branch from e44c940 to 7526a07 Compare July 13, 2021 15:05
@magik6k magik6k enabled auto-merge July 13, 2021 15:07
@magik6k magik6k disabled auto-merge July 13, 2021 15:08
@magik6k magik6k merged commit 583a8a1 into master Jul 13, 2021
@magik6k magik6k deleted the feat/pledge-from-miner-balance branch July 13, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek approved these changes

@jennijuju jennijuju Awaiting requested review from jennijuju

Assignees
No one assigned
Labels
docs-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow PreCommit collateral to be moved from miner available balance
3 participants
@magik6k @arajasek @jennijuju