Update to proofs v8.0.2 with correct aggregate lengths #6524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
commented
Jun 18, 2021
| @@ -544,6 +544,7 @@ func TestSealAndVerifyAggregate(t *testing.T) { | |||
|
|
|||
| avi.Proof, err = ProofProver.AggregateSealProofs(avi, toAggregate) | |||
| require.NoError(t, err) | |||
| require.Len(t, avi.Proof, 11188) | |||
There was a problem hiding this comment.
This number is less than 11220 which we expect in the mock impl, but I'm going to assume that that's caused by the fact that 2k sectors have 10x less snarks
|
We might want to increment the filecoin-ffi soft version, as this does not break binary compatibility but is an important change.https://github.com/filecoin-project/lotus/blob/master/Makefile#L45 |
magik6k
force-pushed
the
feat/proofs-v8.0.2
branch
from
498d3a4 to
738ac92
Compare
Kubuxu
approved these changes
Jun 18, 2021
arajasek
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.