sealing: Fix restartSectors race #6491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
fix/fsm-startup-race2
branch
from
a18e251 to
21ba740
Compare
magik6k
requested review from
arajasek and
jennijuju
and removed request for
whyrusleeping and
Kubuxu
arajasek
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused TestDeadlineToggling (and likely other tests which pledged a bunch of sectors just after startup) to hang.
What happened was that before
Sealing.restartSectorswould run, some other place would start pledging a new sector, which would result inrestartSectorssending aSectorRestartevent, which would cause us to execute the sectors state planer twice, which then would result in the state planner getting duplicate events in wrong states.