Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build snapcraft #6388

Merged
merged 12 commits into from
Jun 7, 2021
Merged

build snapcraft #6388

merged 12 commits into from
Jun 7, 2021

Conversation

coryschwartz
Copy link

@coryschwartz coryschwartz commented Jun 3, 2021

publish snap to the snapcraft store

@coryschwartz coryschwartz force-pushed the feat/ci-snap-release branch from 6e9b035 to 0fba816 Compare June 4, 2021 03:46
@coryschwartz
Copy link
Author

I made some changes to the snapchat build aside from adding the CI logic.

Origionally, I was using the pre-built binaries and just copying them into the snap, and was using ubuntu "core18" as the snap base. With this base, the linking was compatible with the golang docker image (which is debian). However, but this turned out to be a headache to get all the linking right with the golang-16.4 docker image. The binaries built in the build-all step have enough incompatibilty with package versions that it was easier to simply re-build it for the snap.

So now, the binary is built as part of the snap construction and is based on ubuntu 20.04 -- although it will be installable on any linux OS running snap.

@coryschwartz coryschwartz marked this pull request as ready for review June 4, 2021 03:58
@coryschwartz coryschwartz marked this pull request as draft June 4, 2021 17:10
@coryschwartz
Copy link
Author

I made some improvements to make sure this works with strict confinement, and added more detail for https://snapcraft.io/lotus-filecoin

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question.

.circleci/config.yml Outdated Show resolved Hide resolved
@magik6k magik6k merged commit 1c26b72 into master Jun 7, 2021
@magik6k magik6k deleted the feat/ci-snap-release branch June 7, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants