Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the chainstore lock to RW #5971

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Convert the chainstore lock to RW #5971

merged 1 commit into from
Apr 6, 2021

Conversation

ribasushi
Copy link
Collaborator

High read-API concurrency facilitates multiple calls to GetHeaviestTipSet
which in turn could slow down chainsync.

@ribasushi
Convert the chainstore lock to RW
7bced15 
High read-API concurrency facilitates multiple calls to GetHeaviestTipSet
which in turn could slow down chainsync.
magik6k
magik6k approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what can be calling this method so much to cause sync issues, but I guess this is making things very slightly safer (esp. given that Go RWLock is write-preferring)

@magik6k magik6k merged commit 2eda5e8 into master Apr 6, 2021
@magik6k magik6k deleted the chore/switch_lock_to_rw branch April 6, 2021 13:27
@magik6k magik6k mentioned this pull request Apr 13, 2021
Closed
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ribasushi @magik6k