shed command to unpack miner info dumps #5800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/allinfo-utils
branch
from
abb1a15 to
5821376
Compare
Stebalien
approved these changes
Mar 12, 2021
| var minerUnpackInfoCmd = &cli.Command{ | ||
| Name: "unpack-info", | ||
| Usage: "unpack miner info all dump", | ||
| ArgsUsage: "[allinfo.txt] [dir]", |
There was a problem hiding this comment.
nit: call dir output direcctory (i.e., make it clear that this is the output).
|
|
||
| if strings.HasPrefix(sl, "#") { | ||
| if strings.Contains(sl, "..") { | ||
| return xerrors.Errorf("bad name %s", sl) |
There was a problem hiding this comment.
Are we trying to prevent directory traversal? (maybe a comment)
| if err == io.EOF { | ||
| if outf != nil { | ||
| return outf.Close() | ||
| } |
There was a problem hiding this comment.
Maybe return an explicit "we did nothing" error?
Comment on lines
+104
to
+109
| if _, err := outf.Write(l); err != nil { | ||
| return xerrors.Errorf("write line: %w", err) | ||
| } | ||
| if _, err := outf.Write([]byte("\n")); err != nil { | ||
| return xerrors.Errorf("write line end: %w", err) | ||
| } |
There was a problem hiding this comment.
nit: fmt.Fprintln(outf, l) is a bit nicer.
| @@ -35,88 +35,88 @@ var infoAllCmd = &cli.Command{ | |||
|
|
|||
| fmt.Println("#: Version") | |||
| if err := lcli.VersionCmd.Action(cctx); err != nil { | |||
There was a problem hiding this comment.
It would be nice to annotate these errors with what failed (even just a line number).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(also makes the
info alla bit more robust)