Dont publish expired deals #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
magik6k
approved these changes
Feb 2, 2021
| if err != nil { | ||
| return err | ||
| } | ||
| if head.Height() > deal.Proposal.StartEpoch { |
There was a problem hiding this comment.
We could add some config here to allow setting some minimum window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jennijuju pointed out that we should not include deals in a batch publish message if the deal has already expired (the current epoch is greater than the deal proposal start epoch). This PR implements a fix.