Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix helptext for verified-deal default in client deal #5074

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fix helptext for verified-deal default in client deal #5074

merged 1 commit into from
Dec 1, 2020

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Dec 1, 2020 •
edited
Loading

Now:

   --verified-deal              indicate that the deal counts towards verified client total (default: true if client is verified, false otherwise)

Fixes #5073

@magik6k magik6k requested a review from dirkmc December 1, 2020 10:39
@magik6k magik6k mentioned this pull request Dec 1, 2020
Closed
@magik6k magik6k force-pushed the fix/deal-verified-helptext branch from dd73599 to 32065f5 Compare December 1, 2020 10:41
dirkmc
dirkmc approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@magik6k magik6k merged commit 4d019f1 into master Dec 1, 2020
@magik6k magik6k deleted the fix/deal-verified-helptext branch December 1, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deals without --verified-deal parameters are also regarded as Verified Deal
2 participants
@magik6k @dirkmc