Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid sending messages to the zero BLS address #4888

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Avoid sending messages to the zero BLS address #4888

merged 1 commit into from
Nov 17, 2020

Conversation

arajasek
Copy link
Contributor

No description provided.

@arajasek arajasek added this to the 🚢Lotus v1.2.0 milestone Nov 17, 2020
@arajasek arajasek requested a review from vyzo November 17, 2020 07:02
vyzo
vyzo reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine, but what's the rationale for this? bug prevention from accidental sends?

@magik6k magik6k merged commit 425ad9c into release/v1.2.0 Nov 17, 2020
@magik6k magik6k deleted the asr/zero-address branch November 17, 2020 10:57
Kubuxu
Kubuxu reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGWM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu left review comments

@vyzo vyzo vyzo left review comments

@magik6k magik6k magik6k approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
🚢Lotus v1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@arajasek @vyzo @Kubuxu @magik6k