Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd sectors commitIDs len debug #4786

Merged
merged 1 commit into from
Nov 10, 2020
Merged

cmd sectors commitIDs len debug #4786

merged 1 commit into from
Nov 10, 2020

Conversation

zgfzgf
Copy link
Contributor

@zgfzgf zgfzgf commented Nov 10, 2020

activeSet should be sset

lotus/cmd/lotus-storage-miner/sectors.go

Lines 213 to 215 in 3ec25cb

commitedIDs := make(map[abi.SectorNumber]struct{}, len(activeSet))
for _, info := range sset {
commitedIDs[info.SectorNumber] = struct{}{}

whyrusleeping
whyrusleeping approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, nice catch. pretty sure nobody will ever notice, but good for correctness

@magik6k magik6k merged commit 8963241 into filecoin-project:master Nov 10, 2020
@zgfzgf zgfzgf deleted the fix-sectors-cmd-list branch December 4, 2020 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zgfzgf @whyrusleeping @magik6k