Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit events for peer disconnections and act upon them in the blocksync tracker #4754

Merged
merged 2 commits into from
Nov 20, 2020
Merged

emit events for peer disconnections and act upon them in the blocksync tracker #4754

merged 2 commits into from
Nov 20, 2020

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Nov 6, 2020

Closes #92

raulk
raulk requested changes Nov 11, 2020
View reviewed changes
chain/exchange/peer_tracker.go Outdated Show resolved Hide resolved
@vyzo vyzo requested a review from raulk November 20, 2020 14:17
raulk
raulk approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be unfair to ask for tests for the whole component when you're only submitting a patch, but the peer tracker looks untested.

@magik6k magik6k merged commit 3113b15 into master Nov 20, 2020
@magik6k magik6k deleted the fix/issue-92 branch November 20, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

@raulk raulk raulk approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BlockSync should remove syncPeers when peer disconnects
4 participants
@vyzo @raulk @Kubuxu @magik6k