Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate new optional blst backend and verification optimizations from proofs #4630

Merged
merged 7 commits into from
Nov 3, 2020

Conversation

dignifiedquire
Copy link
Contributor

@dignifiedquire dignifiedquire commented Oct 28, 2020

  • Switches blst to the v0.2.0 release, to ensure it matches the version used by blstrs (the recursive dependency integrating blst into filecoin-ffi
  • Updates to use the filecoin-ffi with the latest optimizations for verification and the blst backend

You can enable the blst backend when building from source using FFI_USE_BLST=1

Depends on

Fixes #4678

@dignifiedquire
Copy link
Contributor Author

dignifiedquire commented Oct 28, 2020

Building with the blst backend atm

$ make clean
$ export FFI_BUILD_FROM_SOURCE=1
$ export FFI_USE_BLST=1
$ export RUSTFLAGS="-C target-cpu=native -g"
$ make all

@dignifiedquire dignifiedquire marked this pull request as ready for review November 2, 2020 16:06
@dignifiedquire
Copy link
Contributor Author

I am unclear what the CI failures are about. But I do know that oni will need to remove fil-blst and update filecoin-ffi.

@magik6k magik6k changed the title [WIP] feat: integrate new optional blst backend and verification optimizations from proofs feat: integrate new optional blst backend and verification optimizations from proofs Nov 3, 2020
@magik6k magik6k merged commit 6d27531 into master Nov 3, 2020
@magik6k magik6k deleted the feat/new-blst branch November 3, 2020 10:43
[submodule "extern/oni"]
path = extern/oni
url = https://github.com/filecoin-project/oni
[submodule "extern/blst"]
path = extern/blst
url = [email protected]:supranational/blst.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the build on machines that don't have github pubkeys setup. You need https here, not git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daemon stopped syncing with state root mismatch, restart fixed it
3 participants