Fix memory leaks in data transfer #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
feat/fix-memory-leaks-data-transfer
branch
from
25f588a to
20c2542
Compare
hannahhoward
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
hannahhoward
force-pushed
the
feat/fix-memory-leaks-data-transfer
branch
2 times, most recently
from
0ef3ddd to
58d9cd1
Compare
hannahhoward
force-pushed
the
feat/fix-memory-leaks-data-transfer
branch
from
58d9cd1 to
af1743f
Compare
arajasek
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
We've seen heaving memory usage during large data transfers. This update fixes them on both sides.
For a more in-depth explanation of the fixes see: filecoin-project/go-data-transfer#109
Implementation
The implementation is in upstream packages and there are no changes here
Note: The PRs in Data transfer are not merged and I'd like to get them in master & a tagged release before this goes in LOTUS master.
However, this branch should be adequate for testing by folks who want to see if the issue is resolved.
Resolves #4121 #4468 and associated problems on the client side as well