Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FFI #4613

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Update FFI #4613

merged 3 commits into from
Oct 28, 2020

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Oct 27, 2020 •
edited
Loading

Draft because:

@magik6k magik6k marked this pull request as draft October 27, 2020 14:40
@magik6k magik6k force-pushed the feat/proofs-5.2.3-1 branch 3 times, most recently from 8ef9a13 to 4bf2d76 Compare October 28, 2020 14:45
@magik6k magik6k force-pushed the feat/proofs-5.2.3-1 branch from 4bf2d76 to 86f9abd Compare October 28, 2020 14:47
@magik6k magik6k marked this pull request as ready for review October 28, 2020 14:54
Kubuxu
Kubuxu approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we should add a note about hwloc to docs

@magik6k magik6k merged commit 704bef5 into master Oct 28, 2020
@magik6k magik6k deleted the feat/proofs-5.2.3-1 branch October 28, 2020 16:37
@magik6k magik6k mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magik6k @Kubuxu