tvx simulate command; tvx extract --ignore-sanity-checks #4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
commented
Oct 23, 2020
Comment on lines
+15
to
+21
| // FullAPI is a JSON-RPC client targeting a full node. It's initialized in a | ||
| // cli.BeforeFunc. | ||
| var FullAPI api.FullNode | ||
|
|
||
| // Closer is the closer for the JSON-RPC client, which must be called on | ||
| // cli.AfterFunc. | ||
| var Closer jsonrpc.ClientCloser |
There was a problem hiding this comment.
These are now global vars in the main package initialized by the initialize cli.BeforeFunc.
magik6k
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
tvx simulatecommand that takes a raw base64-encoded CBOR message, and executes it against the provided epoch (or HEAD), generating a vector and optionally printing a statediff that displays the changes made to the state tree.It also introduces an
--ignore-sanity-checksflag ontvx extract, requested by @austinabell.Closes #4476.