Add commands to change the worker key #4513
Conversation
Stebalien
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
| var actorConfirmChangeWorker = &cli.Command{ | ||
| Name: "confirm-change-worker", | ||
| Usage: "Confirm a worker address change", | ||
| ArgsUsage: "[address]", |
There was a problem hiding this comment.
I could drop this flag, but it's nice to check twice.
cmd/lotus-storage-miner/actor.go
Outdated
| if !cctx.Bool("really-do-it") { | ||
| fmt.Println("Pass --really-do-it to actually execute this action") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Probably not necessary for this command?
| worker, err := api.StateAccountKey(ctx, mi.Worker, types.EmptyTSK) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
I assume we just needed to do this to perform the sanity checks inside the miner. I'm now only resolving the worker key there: https://github.com/filecoin-project/lotus/pull/4513/files#diff-e5e6c18c093f7eb4f4d0bb2e19388a831f34ded5ceeff4737091f6dc686aafe6R181-R184
|
Looks like real test failures, still need to figure out what I broke... |
Stebalien
force-pushed
the
steb/feat-change-worker-key
branch
2 times, most recently
from
b1d4653 to
fed47cd
Compare
|
Ok... fixed. |
Stebalien
force-pushed
the
steb/feat-change-worker-key
branch
2 times, most recently
from
f6b0de1 to
43eb06f
Compare
Stebalien
force-pushed
the
steb/feat-change-worker-key
branch
4 times, most recently
from
b86d633 to
9ea309a
Compare
Stebalien
force-pushed
the
steb/feat-change-worker-key
branch
from
9ea309a to
8380c96
Compare
Stebalien
force-pushed
the
steb/feat-change-worker-key
branch
2 times, most recently
from
8f560e0 to
d244d96
Compare
|
Fixed and rebased. |
Stebalien
force-pushed
the
steb/feat-change-worker-key
branch
from
e6f490f to
6790c50
Compare
Stebalien
force-pushed
the
steb/feat-change-worker-key
branch
from
6790c50 to
832c099
Compare
| if s.worker != worker { | ||
| s.worker = worker | ||
| msg.From = s.worker | ||
| return xerrors.Errorf("error getting miner info: %w", err) | ||
| } |
There was a problem hiding this comment.
My original patch didn't bother caching (see above comment) but this was added in by a subsequent commit on master. I can add this back if desired, but it seems unnecessary and storing the key seems error prone.
No description provided.