Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circ supply default in conformance #4449

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Fix circ supply default in conformance #4449

merged 1 commit into from
Oct 22, 2020

Conversation

austinabell
Copy link
Contributor

Seems to not break any vectors rn, but future proof

@austinabell austinabell requested a review from raulk as a code owner October 17, 2020 01:16
raulk
raulk approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-pasta, sorry! None of the vectors that invoke actor methods that require circulating supply carry a nil circSupply, so this should have no impact on the vectors themselves.

@magik6k magik6k merged commit 29cda82 into filecoin-project:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

@raulk raulk raulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@austinabell @raulk @Kubuxu @magik6k