Dump the block validation cache whenever we perform an import #4287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a problem with folks resurrecting long-out-of-sync nodes via snapshot imports. The interface switch to Batching is necessary: startup is too long otherwise ( 8 minutes just to clear everything on a relatively old node )
magik6k
reviewed
Oct 10, 2020
chain/store/store.go
Outdated
| func (cs *ChainStore) FlushValidationCache() error { | ||
| log.Infof("clearing block validation cache...") | ||
|
|
||
| dsWalk, err := cs.ds.Query(query.Query{KeysOnly: true}) |
There was a problem hiding this comment.
Suggested change
| dsWalk, err := cs.ds.Query(query.Query{KeysOnly: true}) | |
| dsWalk, err := cs.ds.Query(query.Query{KeysOnly: true, Prefix: blockValidationCacheKeyPrefix.String()}) |
Then we should be able to drop the prefix check below
There was a problem hiding this comment.
Prefix won't work :(
Prefix is for foo/bar, it doesn't work for foo:bar which is how we assemble the validation cache via .Instance higher up
|
Tested this PR to see if fixes the importing problem, it does! BTW: So this cache clearing is very fast. Complete importing is 8 min. Looking forward to see this merged, I'd like to nuke >20 Lotus nodes |
magik6k
approved these changes
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves (tested on multiple runs) a problem with folks resurrecting long-out-of-sync nodes via
snapshot imports.
The interface switch to Batching is necessary: startup is too long otherwise
( 8 minutes just to clear everything on a relatively old node )