Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-bitfield #4171

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Update go-bitfield #4171

merged 1 commit into from
Oct 5, 2020

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Oct 5, 2020

No description provided.

magik6k
magik6k approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(wait for tests)

Stebalien
Stebalien reviewed Oct 5, 2020
View reviewed changes
go.mod Outdated Show resolved Hide resolved
Update go-bitfield
feb85a2 
Signed-off-by: Jakub Sztandera <[email protected]>
magik6k
magik6k approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more better

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Oct 5, 2020

I love that test-short takes longer than test. Probably will fail there but it is unrelated. It is the same bitfield code after all.

@Stebalien Stebalien merged commit d0c5253 into master Oct 5, 2020
@Stebalien Stebalien deleted the upd/bitfield branch October 5, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien left review comments

@magik6k magik6k magik6k approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kubuxu @Stebalien @magik6k