-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update drand endpoints #4125
Update drand endpoints #4125
Conversation
hsanjuan
commented
Oct 1, 2020
- Remove incentinet (should not be used already)
- Add cloudflare endpoint.
- Switch PL endpoints to HTTP instead of HTTPS.
My opinion: I would tend to keep HTTPs for three reasons:
|
Sorry, to highlight advantages: HTTPS has more latency. There is also a cost associated with running the endpoints (HTTP requests costs less). MiTM is not a risk here, as randomness is verified after fetching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think i have a strong preference on the http/https thing.
adding cloudflare is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing
Thanks @willscott |
Can't sync a fresh node with this PR applied, getting errors like
|
It looks like the chain up to block 51000 was using the incentinet for randomness. |
ad065da
to
3209eb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the test-vectors submodule update intentional?
Adding Cloudflare ensures additional redundancy. Switching to HTTP for PL nodes reduces latency and cost. Randomness is verified after being received.
3209eb1
to
8001ed3
Compare
pretty sure not, fixed. |
I'm syncing ok from scratch, at least 1300 rounds already, so I guess @willscott solved that issue. |
@magik6k this is ready for another merge attempt |