Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move nonce generation out of mpool #3970

Merged
merged 2 commits into from
Sep 29, 2020
Merged

refactor: move nonce generation out of mpool #3970

merged 2 commits into from
Sep 29, 2020

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Sep 23, 2020

Fixes #3957

@dirkmc dirkmc force-pushed the feat/mpool-to-wallet branch 5 times, most recently from 954edaa to 4d7c96a Compare September 24, 2020 12:03
@dirkmc dirkmc force-pushed the feat/mpool-to-wallet branch from 4d7c96a to 3c524ac Compare September 24, 2020 12:09
@dirkmc dirkmc marked this pull request as ready for review September 24, 2020 12:21
@dirkmc dirkmc requested a review from vyzo September 24, 2020 12:21
@dirkmc dirkmc changed the title refactor: move nonce generation from mpool to wallet refactor: move nonce generation out of mpool Sep 24, 2020
vyzo
vyzo reviewed Sep 24, 2020
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good at first pass, but let it bake a bit.

magik6k
magik6k reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and seems to work as expected when testing locally - just 1 comment (+few import nits)

chain/messagesigner/messagesigner.go Outdated Show resolved Hide resolved
node/builder.go Outdated Show resolved Hide resolved
node/impl/full/mpool.go Outdated Show resolved Hide resolved
@dirkmc dirkmc force-pushed the feat/mpool-to-wallet branch from f929030 to d1c10a6 Compare September 29, 2020 10:20
@magik6k magik6k merged commit 1479142 into master Sep 29, 2020
@magik6k magik6k deleted the feat/mpool-to-wallet branch September 29, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo left review comments

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move nonce assignment from Mpool to Wallet
3 participants
@dirkmc @vyzo @magik6k