Validate chain sync response indices when fetching messages #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
|
Note: needs to be tested on the live network; will test in my node after initial review. |
schomatis
previously requested changes
Sep 21, 2020
schomatis
force-pushed
the
fix/chain-sync-validation
branch
from
4f851e9 to
dcf2735
Compare
schomatis
reviewed
Sep 22, 2020
There was a problem hiding this comment.
Removed the message validation from the protocol and made it an API option for the GetChainMessages case. We will always validate the integrity of CompactedMessages, either with blocks retrieved through the protocol or provided by the caller. There is no Validate option then, it's mandatory.
LGTM, but someone else needs to review since I'm too involved in the PR now.
arajasek
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #3887
stricter validation of response indicies