only subscribe to pubsub topics once we are synced #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
previously approved these changes
Sep 7, 2020
|
@schomatis we won't get anything from pubsub until we are synced, our validators are a lot stronger these days and Ignore almost everything when out of sync. |
vyzo
force-pushed
the
feat/delayed-pubsub-join
branch
from
c17a705 to
921d424
Compare
|
fixed the tests and rebased on master. |
vyzo
force-pushed
the
feat/delayed-pubsub-join
branch
from
921d424 to
e33798f
Compare
schomatis
previously approved these changes
Sep 7, 2020
magik6k
reviewed
Sep 7, 2020
magik6k
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we can properly validate stuff.