-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Runtime's Receiver() should only return ID addresses #3589
Conversation
😮 . Could we add an assertion or something directly next to the return point of |
Note to self to implement @anorth's suggestion above^ before merging this |
Uses the new chaos `InspectRuntime` method to test that `Caller()` and `Receiver()` always return an ID address not a robust address. Depends on: * [x] filecoin-project/lotus#3861 Confirmed that the following PR fixes the vector that is broken: * filecoin-project/lotus#3589 resolves #128
c6a9d5a
to
1b801b0
Compare
|
||
func (m *Message) Caller() address.Address { | ||
if m.msg.From.Protocol() != address.ID { | ||
panic("runtime message has a non-ID caller") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay to just panic here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably
Will need to be merged into the 0.9.0 branch behind an upgrade version check |
Good for review, should be merged into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely should get some time in a devnet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High level seems ok
No description provided.